Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Reformat the code a bit #816

Merged
merged 1 commit into from
Oct 27, 2019
Merged

[CLEANUP] Reformat the code a bit #816

merged 1 commit into from
Oct 27, 2019

Conversation

oliverklee
Copy link
Contributor

With the latest version of PHP_CodeSniffer, we can have boolean operators
in the middle of a line as well. This allows us more liberties with code
formatting in order to make to the code more readable.

@oliverklee oliverklee added this to the 4.0.0 milestone Oct 26, 2019
@oliverklee oliverklee self-assigned this Oct 26, 2019
@oliverklee
Copy link
Contributor Author

I'll have a look into the build failures.

@oliverklee
Copy link
Contributor Author

Strange. There is no composer install happening on the failed jobs.

Copy link
Contributor

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's more readable. We've been round this if a few times. I wish I'd written it better in the first place! (But, you live and learn 😒)

@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 27, 2019

Strange. There is no composer install happening on the failed jobs.

I've restarted Travis for the failures. Sometimes Travis randomly fails to set up the environment correctly. Odd that the failures were all PHP 7.0, which looks less like random failure than a potential issue. Watch this space...

@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 27, 2019

Strange. There is no composer install happening on the failed jobs.

I've restarted Travis for the failures. Sometimes Travis randomly fails to set up the environment correctly. Odd that the failures were all PHP 7.0, which looks less like random failure than a potential issue. Watch this space...

It's still not installing any of the 'dev' dependencies. Travis itself is broken. Sigh.

With the latest version of PHP_CodeSniffer, we can have boolean operators
in the middle of a line as well. This allows us more liberties with code
formatting in order to make to the code more readable.
@oliverklee
Copy link
Contributor Author

Repushed. Hopefully, the build will be green now.

@JakeQZ JakeQZ merged commit 7d7513a into master Oct 27, 2019
@JakeQZ
Copy link
Contributor

JakeQZ commented Oct 27, 2019

Hopefully, the build will be green now.

This one is. There's another random failure on master that I've restarted (and now succeeded).

@JakeQZ JakeQZ deleted the cleanup/formatting branch October 27, 2019 22:39
@JakeQZ JakeQZ mentioned this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants