Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/top-nav-issue #341

Merged
merged 22 commits into from
Jan 5, 2019
Merged

bug/top-nav-issue #341

merged 22 commits into from
Jan 5, 2019

Conversation

gamalielhere
Copy link
Contributor

Bug

@gamalielhere gamalielhere added Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge labels Jan 3, 2019
gamalielhere and others added 2 commits January 2, 2019 18:01
@gamalielhere
Update changelog
e2c34ed
@hsurf22
Update scroll up button animation
d6f2f54 
After clicking create wallet 'next button', screen will scroll up
@codecov
Copy link

codecov bot commented Jan 3, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (devop/refactoring@6e41297). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             devop/refactoring     #341   +/-   ##
====================================================
  Coverage                     ?   17.78%           
====================================================
  Files                        ?      340           
  Lines                        ?     4784           
  Branches                     ?      629           
====================================================
  Hits                         ?      851           
  Misses                       ?     3630           
  Partials                     ?      303
Impacted Files Coverage Δ
src/containers/HeaderContainer/HeaderContainer.vue 0% <ø> (ø)
src/builds/web/app.vue 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e41297...c53e01d. Read the comment docs.

@gamalielhere gamalielhere requested a review from kvhnuke January 4, 2019 21:34
@gamalielhere gamalielhere changed the base branch from develop to devop/refactoring January 4, 2019 23:59
@gamalielhere gamalielhere merged commit 6353965 into devop/refactoring Jan 5, 2019
@gamalielhere gamalielhere deleted the bug/top-nav-issue branch January 5, 2019 00:01
This was referenced Mar 19, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMieskoski SteveMieskoski SteveMieskoski approved these changes

@kvhnuke kvhnuke Awaiting requested review from kvhnuke

Assignees
No one assigned
Labels
Bug Issues identified. Should be re-labeled to Fatal, or won't fix based on that Ready Tag for when a PR is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gamalielhere @SteveMieskoski @mew-bot @hsurf22