Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up test runs #3935

Merged
merged 3 commits into from
Apr 16, 2021
Merged

Speed up test runs #3935

merged 3 commits into from
Apr 16, 2021

Conversation

FrederikBolding
Copy link
Collaborator

Is roughly 60% faster at running tests on my machine compared to having maxWorkers=2

@FrederikBolding FrederikBolding temporarily deployed to STAGING April 15, 2021 11:56 Inactive
@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #3935 (cfbf75f) into master (503446c) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3935      +/-   ##
==========================================
- Coverage   66.45%   66.35%   -0.10%     
==========================================
  Files         578      578              
  Lines       12120    12120              
  Branches     3088     3088              
==========================================
- Hits         8054     8042      -12     
- Misses       4034     4046      +12     
  Partials       32       32              
Impacted Files Coverage Δ
src/services/Store/BalanceService.tsx 71.55% <0.00%> (-10.10%) ⬇️
src/services/Store/StoreProvider.tsx 38.02% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503446c...cfbf75f. Read the comment docs.

@FrederikBolding FrederikBolding temporarily deployed to STAGING April 15, 2021 12:07 Inactive
package.json Outdated Show resolved Hide resolved
@@ -221,7 +221,7 @@
"build": "cross-env TARGET_ENV=default webpack --config webpack_config/production.js",
"build:staging": "cross-env TARGET_ENV=staging webpack --config webpack_config/production.js",
"prebuild": "check-node-version --package",
"test": "jest --config=jest_config/jest.config.json --maxWorkers=2",
"test": "jest --config=jest_config/jest.config.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move jest.config.json to the root (like in signer)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope

vilsbole
vilsbole previously approved these changes Apr 16, 2021
@Mrtenz Mrtenz merged commit e03c0cc into master Apr 16, 2021
@Mrtenz Mrtenz deleted the fb/speed-up-tests branch April 16, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants