Handle payjoin errors according to BIP 78 #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanGould
force-pushed
the
pj-response-errors
branch
5 times, most recently
from
e2a168c to
6ba4da0
Compare
benthecarman
approved these changes
Jan 5, 2024
|
needs rebase |
DanGould
force-pushed
the
pj-response-errors
branch
from
6ba4da0 to
18e23cf
Compare
Open
|
I'm not sure why these platform-specific errors are happening in CI after rebase since they don't seem to relate to my changes. @benthecarman any hints? |
|
Maybe just try rebasing? seems like a spurious failure |
"The receiver is allowed to return implementation specific errors which may assist the sender to diagnose any issue. However, it is important that error codes that are not well-known and that the message do not appear on the sender's software user interface. Such error codes or messages could be used maliciously to phish a non- technical user. Instead those errors or messages can only appear in debug logs. It is advised to hard code the description of the well known error codes into the sender's software." See: https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki#receivers-well-known-errors This commit displays templates based on a particular \`ResponseError\` and debugs the rest, according to this specification.
DanGould
force-pushed
the
pj-response-errors
branch
from
18e23cf to
6e5bd38
Compare
|
yep it was spurious |
benthecarman
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit displays templates based on a particular
ResponseErrorand debugs the rest, according to this specification.
See:
https://github.com/bitcoin/bips/blob/master/bip-0078.mediawiki#receivers-well-known-errors
result:
