-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fedimint #867
Add fedimint #867
Conversation
1490040
to
40d7c03
Compare
6c8fd87
to
42a5801
Compare
678e341
to
d65918f
Compare
1213ec7
to
4ea9d43
Compare
47a10be
to
5e0aa52
Compare
1842a44
to
1ea8a05
Compare
dd08f73
to
1f1a398
Compare
1f1a398
to
c2c32ca
Compare
This is ready @benthecarman I say we handle LNURL pay/withdraw in a follow up along with you fixing a couple of the NWC tests in a follow up too. I don't think they'd require any foundational change, mostly a bit of manual work that's not worth blocking on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 2 nits
0b82e8e
to
7a053f7
Compare
7a053f7
to
f45ab40
Compare
@benthecarman please review the last 3 commits.
|
f45ab40
to
a948a8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny nit, otherwise lgtm.
You can just take my commit and merge it into your last one if you want, would make the commits a little cleaner.
a948a8a
to
3b120ca
Compare
Done |
3b120ca
to
2a53516
Compare
🚢 it 🚀 |
TODO:
Follow up: