Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fedimint #867

Merged
merged 12 commits into from
Dec 21, 2023
Merged

Add fedimint #867

merged 12 commits into from
Dec 21, 2023

Conversation

TonyGiorgio
Copy link
Contributor

@TonyGiorgio TonyGiorgio commented Nov 19, 2023

TODO:

  • payment storage in gluesql
  • Get labels to work properly with fedimint payments
  • NWC Invoice Payer

Follow up:

  • LNURL out of fedimint

@TonyGiorgio TonyGiorgio force-pushed the add-fedimint branch 6 times, most recently from 1490040 to 40d7c03 Compare November 22, 2023 05:17
@TonyGiorgio TonyGiorgio force-pushed the add-fedimint branch 2 times, most recently from 6c8fd87 to 42a5801 Compare November 23, 2023 21:22
@TonyGiorgio TonyGiorgio force-pushed the add-fedimint branch 2 times, most recently from 678e341 to d65918f Compare November 24, 2023 01:49
@TonyGiorgio TonyGiorgio force-pushed the add-fedimint branch 3 times, most recently from 1213ec7 to 4ea9d43 Compare November 27, 2023 21:55
mutiny-core/src/fedimint.rs Outdated Show resolved Hide resolved
mutiny-core/src/fedimint.rs Outdated Show resolved Hide resolved
@TonyGiorgio TonyGiorgio force-pushed the add-fedimint branch 4 times, most recently from 47a10be to 5e0aa52 Compare November 28, 2023 20:58
@benthecarman benthecarman mentioned this pull request Nov 28, 2023
2 tasks
@TonyGiorgio TonyGiorgio force-pushed the add-fedimint branch 5 times, most recently from 1842a44 to 1ea8a05 Compare November 29, 2023 03:36
@TonyGiorgio TonyGiorgio marked this pull request as ready for review December 20, 2023 22:31
@TonyGiorgio
Copy link
Contributor Author

This is ready @benthecarman

I say we handle LNURL pay/withdraw in a follow up along with you fixing a couple of the NWC tests in a follow up too. I don't think they'd require any foundational change, mostly a bit of manual work that's not worth blocking on.

Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 2 nits

mutiny-core/src/lib.rs Outdated Show resolved Hide resolved
mutiny-core/src/lib.rs Outdated Show resolved Hide resolved
@TonyGiorgio
Copy link
Contributor Author

@benthecarman please review the last 3 commits.
I've done the following:

  • Removed more references to node_manager and node inside of nwc
  • Added another method to the trait in order to handle invoice creation (for one time nwc)
  • I've renamed LnPayer to InvoiceHandler since it now generates, checks, and pays invoices

Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit, otherwise lgtm.

You can just take my commit and merge it into your last one if you want, would make the commits a little cleaner.

mutiny-core/src/lib.rs Outdated Show resolved Hide resolved
@TonyGiorgio
Copy link
Contributor Author

one tiny nit, otherwise lgtm.

You can just take my commit and merge it into your last one if you want, would make the commits a little cleaner.

Done

@benthecarman
Copy link
Collaborator

🚢 it 🚀

@TonyGiorgio TonyGiorgio merged commit ccf3631 into master Dec 21, 2023
9 checks passed
@TonyGiorgio TonyGiorgio deleted the add-fedimint branch December 21, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants