Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release vss lock when stop is called #846

Closed
wants to merge 1 commit into from
Closed

release vss lock when stop is called #846

wants to merge 1 commit into from

Conversation

futurepaul
Copy link
Contributor

was hoping this would fix flaky test. it didn't I don't think, but it's still an improvement (especially when restoring in place)

benthecarman
benthecarman reviewed Nov 11, 2023
View reviewed changes
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rustfmt

Logically, this makes sense to me. I fear about merging right now as we're trying to nail down double init errors. This would just add to the confusion.

@benthecarman benthecarman deleted the release-lock-on-stop branch February 5, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benthecarman benthecarman benthecarman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@futurepaul @benthecarman @TonyGiorgio