Remove max invoice fee #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
invoice-fee-max
branch
from
64212e3 to
002c411
Compare
benthecarman
force-pushed
the
invoice-fee-max
branch
from
002c411 to
3278b18
Compare
TonyGiorgio
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TonyGiorgio was getting payment failures, the logs indicate that the fee limit was the culprit lightningdevkit/rust-lightning#2718
This makes it so we don't use LDK's default of 1% + 50 sats for the max fee and just allow any fee in the name of trying to get every payment to work.
Can revert after lightningdevkit/rust-lightning#2719