-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolt 12 #806
base: master
Are you sure you want to change the base?
Bolt 12 #806
Conversation
6cb4ff5
to
03660b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see some early adoption! Please let us know if you run into any issues.
if !offer.supports_chain(ChainHash::using_genesis_block(self.network)) { | ||
return Err(MutinyError::IncorrectNetwork(self.network)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ChannelManager::pay_for_offer
should already checks this when it sets the chain on the InvoiceRequestBuilder
.
if !self.channel_manager.list_usable_channels().is_empty() { | ||
break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, to be certain this would need to check for a usable channel with an introduction node in the Offer
's blinded path (or with its signing pubkey if doesn't have any blinded paths).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we just do this to make sure the node is fully booted up
3577bbb
to
4134f61
Compare
FYI, if you implement your own |
@jkczyz pusshed up what i have, isn't currently working however, gets this error |
Hmm... seems like you are getting an invoice at least. The failure is from trying to pay it. The "retry" portion of the message may be misleading though as it used for the initial send. Let's sync up tomorrow to debug. |
68627a0
to
e4408b5
Compare
This can pay bolt 12 offers!
bolt12 made by the LSP:
need to add tests that all the storage around bolt11 vs bolt12 is handled properly, probably some cleanup can be done too