Use alternative retry method for async storage #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
different-retry
branch
3 times, most recently
from
659c5de to
4fb675b
Compare
benthecarman
force-pushed
the
different-retry
branch
from
4fb675b to
eec41fa
Compare
|
Cool, thanks. Will try to reproduce the issue locally and then see if this fixes it. It wasn't something I could reliably reproduce, even turning the browser network speed to 3g. |
TonyGiorgio
approved these changes
Oct 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TonyGiorgio and some other people have been reporting some issues with storage getting stuck. Not entirely sure what the issue is but this could be a fix. Changes the storage retries to be done by listing all the pending updates and persisting them in a loop rather than continually retrying on an individual update. This also lets us persist locally for retries since we are persisting the current monitor for retries, instead of the one that failed, so we don't have to worry about a race condition.