Don't persist NetworkGraph #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
approved these changes
Sep 24, 2023
|
Wait it's possible someone doesn't have it set to read from RGS tho right? |
Yeah I guess, we don't do anything for that right now |
We no longer read the graph from storage, we just get it from RGS on boot, so there's no reason to persist it. We can also not save it in our memory storage because we don't need to read it.
benthecarman
force-pushed
the
dont-persist-graph
branch
from
7ade07c to
b59c278
Compare
TonyGiorgio
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer read the graph from storage, we just get it from RGS on boot, so there's no reason to persist it.
We can also not save it in our memory storage because we don't need to read it.
This should help with the memory out of bounds issue