Fix monitor version parsing #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
fix-monitor-parsing
branch
from
52e1300 to
f2717d1
Compare
|
Is this testable at all? |
|
The We had some tests already, just with fake data. We can add ones with real world data, that'd be better. |
benthecarman
force-pushed
the
fix-monitor-parsing
branch
from
f2717d1 to
b091381
Compare
benthecarman
force-pushed
the
fix-monitor-parsing
branch
from
b091381 to
9df4e94
Compare
|
Okay tests now use real monitors from a signet node I made |
TonyGiorgio
approved these changes
Sep 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous we were parsing the version number wrong, we had been parsing one of the version bytes as part of update_id bytes. This fixes it and adds an
debug_assertto test it in any debug build.Fixes #721