Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors support #762

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Anchors support #762

merged 1 commit into from
Sep 27, 2023

Conversation

benthecarman
Copy link
Collaborator

haven't tested but this would at least let us play with anchors

we probably would want to make this optional

@TonyGiorgio
Copy link
Contributor

TonyGiorgio commented Sep 18, 2023

Should we change this value at all?

fn num_blocks_from_conf_target(confirmation_target: ConfirmationTarget) -> usize {
match confirmation_target {
// MempoolMinimum is only used for anchor channels which we don't support.
// Just setting it to the max confirmation target for now.
ConfirmationTarget::MempoolMinimum => 1008,
// Background is VERY lax and may never confirm if used directly
// it is only meant for lower ranges of transaction to enter mempool
ConfirmationTarget::Background => 1008,
ConfirmationTarget::Normal => 6,
ConfirmationTarget::HighPriority => 3,
}
}

@benthecarman
Copy link
Collaborator Author

Looks like for ldk-sample they are using 144 blocks for Background, we could change to that and keep MempoolMinimum. However it is probably better to be safe than sorry, we don't wanna cause force closures again.

@benthecarman benthecarman merged commit 9289d6e into master Sep 27, 2023
9 checks passed
@benthecarman benthecarman deleted the anchors branch September 27, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants