Skip hermes check if we don't have a ln address #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
approved these changes
Jun 21, 2024
Comment on lines
+183
to
+187
|
|
||
| // if we don't have a lightning address, no need to continue | ||
| if o.name.is_none() { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Something seems strange to me about this code. I think this works, but would it make more sense to have Ok(Some(u)) and Ok(None)? It would probably need to do the same current_address_check_clone stuff but make be more logical to seperate when the user has a name registered and not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our sentry was getting filled up with logs of people who were getting a log because they don't have a lightning address.