Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for olympus swaps #1202

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fixes for olympus swaps #1202

merged 1 commit into from
Jun 6, 2024

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Jun 6, 2024

Previously when doing a swap we'd get an extra channel sometimes because we'd call the fee api multiple time which would cause the olympus node to open the extra channel. To make sure we only call the fee api once, we need to generate the invoice when estimating fee and then when we execute the swap, use that invoice, this way we can guarantee there is only a single call to the api for a given swap.

For testing use this: https://mutinynet-lsps1.lnolymp.us

I tested:

  • fedimint -> lightning w/ no channels
  • fedimint -> lightning w/ channel and enough inbound
  • fedimint -> lightning w/ channel and not enough inbound
  • fedimint -> fedimint

@benthecarman benthecarman added the bug Something isn't working label Jun 6, 2024
@benthecarman benthecarman requested a review from TonyGiorgio June 6, 2024 17:13
@TonyGiorgio
Copy link
Contributor

Does this still work with the voltage LSP?

@benthecarman
Copy link
Collaborator Author

Does this still work with the voltage LSP?

yes

@TonyGiorgio TonyGiorgio merged commit e2a469b into master Jun 6, 2024
9 checks passed
@TonyGiorgio TonyGiorgio deleted the zeus-swap-fixes branch June 6, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants