Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better fedimint update streams #1157

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Better fedimint update streams #1157

merged 3 commits into from
Apr 26, 2024

Conversation

TonyGiorgio
Copy link
Contributor

@TonyGiorgio TonyGiorgio commented Apr 24, 2024 •
edited
Loading

This focuses more on streams than continuous polling. Quite a few TODOs and cleanups needed but it functionally works. Should be able to finish tomorrow.

Fixes #1138

@TonyGiorgio
Copy link
Contributor Author

Two minor things but otherwise ready for a first pass.

benthecarman
benthecarman reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In get_invoice_by_hash we have it look up in the fedimint operation logs as well. Do we still need that? Now it should be subscribed for every invoice so we can just trust storage.

mutiny-core/src/federation.rs Outdated Show resolved Hide resolved
mutiny-core/src/federation.rs Outdated Show resolved Hide resolved
mutiny-core/src/federation.rs Outdated Show resolved Hide resolved
mutiny-core/src/federation.rs Outdated Show resolved Hide resolved
@benthecarman
Copy link
Collaborator

would be good to fix #1138 here

@benthecarman benthecarman linked an issue Apr 25, 2024 that may be closed by this pull request
Failed fedimint payments keep looping #1137
Closed
@TonyGiorgio TonyGiorgio force-pushed the fedimint-streams branch 6 times, most recently from 5ff5f32 to b303c50 Compare April 26, 2024 01:50
@TonyGiorgio TonyGiorgio marked this pull request as ready for review April 26, 2024 01:50
@TonyGiorgio TonyGiorgio merged commit 2380835 into master Apr 26, 2024
9 checks passed
@TonyGiorgio TonyGiorgio deleted the fedimint-streams branch April 26, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benthecarman benthecarman benthecarman approved these changes

Assignees
No one assigned
Labels
fedimint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set last_updated when fedimint payments complete Failed fedimint payments keep looping
2 participants
@TonyGiorgio @benthecarman