nwc fixups #1155
Merged
nwc fixups #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncantrell97
force-pushed
the
nwc-fixups
branch
3 times, most recently
from
85ff336 to
db014b4
Compare
johncantrell97
force-pushed
the
nwc-fixups
branch
from
db014b4 to
361a94a
Compare
johncantrell97
force-pushed
the
nwc-fixups
branch
from
361a94a to
a3aba9f
Compare
benthecarman
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small fixes for NWC:
Return error event for events sent to inactive profiles. Even though you mentioned it's not something that users should run into since you delete profiles instead of archive, the logic to skip events is still there. Would be best to respond so the user who made the request can get some feedback about what is going on. At a minimum should log the error.
If create_invoice fails it would be nice to respond with an error to the user requesting the invoice.