Hermes address change #1130
Merged
Hermes address change #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyGiorgio
force-pushed
the
hermes-address-change
branch
2 times, most recently
from
fe99456 to
3185345
Compare
benthecarman
approved these changes
Apr 11, 2024
Comment on lines
+438
to
+447
| // make sure name is registered already | ||
| if current_address.read().await.0.is_none() { | ||
| return Ok(()); | ||
| } |
There was a problem hiding this comment.
This and the one for disable_zaps has a minor race condition if the user manages to remove/switch federation before the check call has finished. Could do rechecking until .1 is true
|
need to see if the user is enabled or disabled with zaps to know if we need to call disable-zaps on init if they do not have a federation. other wise it keeps calling it even if the server already knows that. |
TonyGiorgio
force-pushed
the
hermes-address-change
branch
from
affbca6 to
ba2bf0f
Compare
benthecarman
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.