Replace instant dependency with web-time #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
requested changes
Apr 2, 2024
|
This crate is just an alias for See: https://github.com/daxpedda/web-time/blob/main/src/lib.rs |
|
Yeah but then we need to trust that dep vs just doing less of 10 lines of code to handle it ourself |
DanGould
force-pushed
the
web-time
branch
2 times, most recently
from
0535dca to
b805c40
Compare
web-time offers a number of advantages over the instant crate - Actively maintained - Stable 1.x API - Exact std::time replacement - Compatible with rustls pki-types web feature - Re-exports std::time when not targeting wasm32-unknown-unknown without pulling in any dependencies
|
Thanks for the prompt review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-time offers a number of advantages over the instant crate