Fix typo in documentation: Starring not Staring. #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't staring at our commits, we are adding stars.
mwerle
approved these changes
Aug 18, 2023
|
I don't understand github's new "At least 1 approving review is required by reviewers with write access." maybe you don't have write access? I don't see any merge button anywhere, feel free to merge. I can't unless I'm missing something somewhere. |
|
Ah, maybe you also don't have write access. Makes sense, ok. |
Indeed I don't.. don't really know how this repo is being run.. just figured doing a review would allow the owner(s) to merge this more quickly. |
|
I will merge it when the CI is going through. Thank you for the contribution! |
Murmele
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't staring at our commits, we are adding stars.