Referring repos with their git-dir instead of their work-tree. #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murmele
reviewed
Aug 27, 2023
What do you mean here? |
|
Gittyup has an interface to connect to repo from Github, GitLab, etc. I did not check if my patch affects this. |
|
I will check it out as next. Sorry for having to wait. Quite busy at the moment |
|
Not a problem ! I am not waiting btw, I'm using my fork right now, so I already enjoy the feature I was missing. |
Also sets up display routines to avoid displaying a repo as ".git".
Co-authored-by: Murmele <[email protected]>
Murmele
force-pushed
the
betterHistory
branch
from
3c65264
to
8374baa
Compare
|
Old behaviour: Using the workdir path
|
…ectly when requesting the path, otherwise the settings are stored inconsistently and might lead to an infinity loop in void RecentRepositories::load()
|
@ysalmon for me this part with .git makes problems and I am entering an infinity loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also sets up display routines to avoid displaying a repo as ".git" : we display the penultimate component of the path when the last one is ".git". This assumes nobody creates a repo in
/.git.This closes #612.
This needs review, especially wrt opening "remote" repos, which I did not test.
One will need to purge one's repo history on upgrading to this version.