-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing error when I import "ShareButtonsModule" in application #17
Comments
Hi @Binal24, Have you upgraded angular-cli to 1.0.0-beta.24? Check this |
This package needs to be recompiled, by the time I push the new updates you can use the source typescript in your project |
Yes I am using angular-cli 1.0.0-beta.24 version. |
@Binal24 I don't think so, but next release will ship typescript files instead of compiled ones to avoid such issues in the future |
Hi @MurhafSousli, Regarding this issue, the recommenced solution is to publish the To do so, you must use the @angular/compiler-cli (ngc), which is a drop-in replacement for Typescript compiler (tsc) with some additional Angular magic, like generating those modules metadata and being AoT compliant. I have a working PR ready to push if you want (tested with latest angular-cli v1.0.0-beta-24) Cheers |
- ts files are now compiled with `@angular/compiler-cli` (ngc) instead of tsc - `*.metadata.json` are now published along with `*.d.ts files` (Fixes MurhafSousli#17) - `index.ts` have been renamed into `share-buttons.module.ts` and moved to `src` folder - new `index.ts` importing the `share-buttons.module.ts` has been added to `src` folder - gulp tasks have been reorganized and useless plugin removed (merge2 sourcemaps,...)
Showing below error like,
"ShareButtonsModule is not an NgModule"
Please help me out for this error.
The text was updated successfully, but these errors were encountered: