Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The gist class member of the GistDirective is private #242

Closed
webpreneur opened this issue Dec 17, 2022 · 0 comments · Fixed by #244
Closed

The gist class member of the GistDirective is private #242

webpreneur opened this issue Dec 17, 2022 · 0 comments · Fixed by #244

Comments

@webpreneur
Copy link

webpreneur commented Dec 17, 2022 •
edited
Loading

Reproduction

Steps to reproduce:

  1. Import HighlightPlusModule
  2. Use gist attribute on pre element.

Expected Behavior

What behavior were you expecting to see?

The gist setter to have public access modifier.

Actual Behavior

What behavior did you actually see?

"Property 'gist' is private and only accessible within class 'GistDirective'.ngtsc(2341)"

Environment

  • Angular: 15.0
  • ngx-highlightjs: ^7.0.1
  • Operating System (e.g. Windows, macOS, Ubuntu): WSL Ubuntu 20
MurhafSousli added a commit that referenced this issue Jan 1, 2023
@MurhafSousli
Make gist setter public, closes #242
3208b0d
@MurhafSousli MurhafSousli linked a pull request Jan 1, 2023 that will close this issue
Update to Angular 15 #244
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Angular 15 MurhafSousli/ngx-highlightjs
1 participant
@webpreneur