Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the desktop entry #4966

Open
1 task done
mrmeszaros opened this issue Nov 3, 2022 · 0 comments · May be fixed by #4971
Open
1 task done

Refactor the desktop entry #4966

mrmeszaros opened this issue Nov 3, 2022 · 0 comments · May be fixed by #4971
Labels
suggestion Feature suggestions that have not been accepted yet. system: Linux Linux specific issues (dependency hell, packaging, etc.)

Comments

@mrmeszaros
Copy link

mrmeszaros commented Nov 3, 2022 •
edited
Loading

Role

I use MultiMC

Suggestion

I want the desktop icon to be themed

Benefit

so that when I apply a desktop theme, MutliMC fits nicely

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

Currently, the MultiMC desktop entry has it's icon line hardcoded, which disables the ability for freedesktop icon theming.

[Desktop Entry]
...
Icon=/opt/multimc/icon.svg
...

I suggest the icon to be installed to one of the standard icon folders (most likely /usr/share/icons/hicolor/scalable/apps/multimc.svg - source), and referenced by its basename (Icon=multimc).
This way an application icon theme (eg.: Numix) can seamlessy override it when applied.
@phit phit added system: Linux Linux specific issues (dependency hell, packaging, etc.) suggestion Feature suggestions that have not been accepted yet. labels Nov 3, 2022
mrmeszaros added a commit to mrmeszaros/MultiMC-Launcher that referenced this issue Nov 8, 2022
@mrmeszaros
MultiMCGH-4966 Refactor the desktop entry
38c9f0b 
Changed the desktop file icon lookup, to enable app icon theming.
The Icon line uses the icon name instead of the full path.
For this to work, the icon is moved to a directory specified by the
standard (`/usr/share/icons/hicolor/scalable/apps/`).
As the standard highly suggests, a 48x48 png icon is also added
(rendered from the svg with inkscape).

Added the `StartupWMClass` directive, so that window managers can
associate the created windows with the desktop icon.

Changed the rpm spec file to reflect the aforementioned changes.

Fixes MultiMC#4966
@mrmeszaros mrmeszaros linked a pull request Nov 8, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion Feature suggestions that have not been accepted yet. system: Linux Linux specific issues (dependency hell, packaging, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-4966 Refactor the desktop entry mrmeszaros/MultiMC-Launcher
2 participants
@phit @mrmeszaros