-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V0.6.14-develop-3019 on Win32][Windows 10 64] Launcher not detecting internet access after system sleep #4356
Comments
I have this problem as of public version 0.6.14, always prompts me for my offline username when launching the game from sleep/hibernation. Have to close and restart MultiMC for it to connect again. |
At least for me, this appears to be a DNS issue - specifically, an inability to resolve Possible cause: on my machine, the network adapter takes a few seconds to come online after wake-from-sleep, which is likely what causes the name resolution to fail. However, this did only start happening with the most recent release (upgrading from (Side note: would it be acceptable to modify the MultiMC logger to output absolute timestamps on each log line, rather than timestamps relative to program start? I find the absolute timestamps much more useful for debugging :]) |
Yeah, I'm having this trouble too, but I have (incorrectly?) attributed it to when my Windows machine loses access to its internet connection sometime while the app was running, i.e., if the internal WiFi dropped its connection. I would expect that re-establishing a WiFi connection would allow me to use "Launch" without seeing the offline prompt. I, too, can workaround the problem by restarting MultiMC. I'm seeing this problem with Version 0.6.15-develop-3227 on win 32. |
Version 0.6.16-3431 on win32 running Windows 10 and it's still happening. I wake my computer from hibernation or sleep, and try to launch anything from a still open MultiMC, and it prompts for offline name, indicating offline. I have to manually click on the account selection, Manage Accounts, select my account and hit refresh. Only then can I launch without being prompted or having to restart MultiMC. Suggestion: On failure to resolve, set a timer starting at say 15 seconds after the first error to resolve, and on every subsequent failure, increase the wait period by doubling the current value for the next timer, set a cap of say 1-2 or even 4 minutes. You won't make tons of requests for no reason, and wait reasonable periods of time to resolve the underlying issue (i.e. lazy/buggy nic driver) and continue at a reasonable pace. This methodology can also be applied in reverse if you're seeking to check you're still online by pinging a server or something for general tracking purposes. |
In the login function of LaunchController, added requestRefresh on the current m_accountToUse. This allows the accountState of accountToUse to be updated before running through what login is meant to depending on the accountState. This is to allow for the cases where a device might be back online after launching the Launcher. Putting this in the tryagain while loop also allows to check if a users account is expired during the login process.
Operating System
Windows
Description of bug
Launcher should detect internet connection coming back up similar to how it detects when down.
Steps to reproduce
Run current Dev release of MultiMC on Windows 10 64
Launch an instance
[optional] Close instance from 2
Keep launcher running
"Sleep" the Windows machine (I've been doing overnight, unknown how long is needed, probably fairly instant)
"Wake" machine / login
Launch an instance
... at this point, step 7, even after 30 minutes, MultiMC still prompts for offline username (which it never does in step 2)
Not a big deal, just filing to get it off of my brain every time it happens :)
Suspected cause
No response
This issue is unique
The text was updated successfully, but these errors were encountered: