Skip to content

Commit

Permalink
Artifact + Matrix - 7
Browse files Browse the repository at this point in the history
Updating Dockerfiles to use ARG environment variable with latest timestamp that will be passed through:
- `docker build --build-arg` command in Github actions in the workflow for automated pushing to Docker hub.
- `args: ` config field in docker-compose which will need to be set manually by developers locally.

Also, changing branch in fetch_runID and Dockerfiles to tags-combo-approach.
  • Loading branch information
Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed May 2, 2024
1 parent 340d9d0 commit 15c9da1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/fetch_runID.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
successful_runs = [run for run in workflow_runs \
if run["status"] == "completed" and \
run["conclusion"] == "success" and \
run["head_branch"] == "tags-artifact"
run["head_branch"] == "tags-combo-approach"
]
# print(successful_runs)
if successful_runs:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Please change once all PR changes are final, so it reads from shankari/e-mission-server
# FROM shankari/e-mission-server:master_2024-02-10--19-38
ARG DOCKER_IMAGE_TAG
FROM mukuflash03/e-mission-server:image-push-merge_${DOCKER_IMAGE_TAG}
FROM mukuflash03/e-mission-server:tags-combo-approach_${DOCKER_IMAGE_TAG}

ENV DASH_DEBUG_MODE True
ENV SERVER_PORT 8050
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Please change once all PR changes are final, so it reads from shankari/e-mission-server
# FROM shankari/e-mission-server:master_2024-02-10--19-38
ARG DOCKER_IMAGE_TAG
FROM mukuflash03/e-mission-server:image-push-merge_${DOCKER_IMAGE_TAG}
FROM mukuflash03/e-mission-server:tags-combo-approach_${DOCKER_IMAGE_TAG}

ENV DASH_DEBUG_MODE True
ENV SERVER_PORT 8050
Expand Down

0 comments on commit 15c9da1

Please sign in to comment.