Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File dialogs reappear after cancellation (Open/Save/Save As) #243

Closed
Muhammed-Rahif opened this issue Nov 23, 2024 · 2 comments
Closed

File dialogs reappear after cancellation (Open/Save/Save As) #243

Muhammed-Rahif opened this issue Nov 23, 2024 · 2 comments
Assignees
@Muhammed-Rahif
Labels
bug Something isn't working, should be fixed priority: critical Critical priority issue/pull request released on @alpha
Milestone
v1.0

Comments

@Muhammed-Rahif
Copy link
Owner

Reproduction Steps:

  1. Go to File > Open and click Cancel on the dialog.
  2. The dialog reappears immediately after being canceled.
  3. A similar issue occurs with the Save and Save As dialogs: when clicking Cancel, the file is saved regardless.

Issue reported by: @Skhmt on dev.to comment
@Muhammed-Rahif Muhammed-Rahif added bug Something isn't working, should be fixed priority: critical Critical priority issue/pull request labels Nov 23, 2024
@Muhammed-Rahif Muhammed-Rahif self-assigned this Nov 23, 2024
@Muhammed-Rahif Muhammed-Rahif added this to the v1.0 milestone Nov 23, 2024
Muhammed-Rahif added a commit that referenced this issue Nov 24, 2024
@Muhammed-Rahif
fix(files): file dialogs reappear after cancellation (open/save/save As)
dc7c4a7 
resolves #243
@Muhammed-Rahif
Copy link
Owner Author

Resolved dc7c4a7

github-actions bot pushed a commit that referenced this issue Dec 2, 2024
@semantic-release-bot
chore(release): 1.0.0-alpha.4 [skip ci]
e3a86c7 
# [1.0.0-alpha.4](v1.0.0-alpha.3...v1.0.0-alpha.4) (2024-12-02)

### Bug Fixes

* **dialog:** made content scrollable, header & footer sticky ([1a2b443](1a2b443))
* **editor:** fake caret animation improvements ([b6d83b1](b6d83b1))
* **files:** file dialogs reappear after cancellation (open/save/save As) ([dc7c4a7](dc7c4a7)), closes [#243](#243)
* **menubar:** only show latest release downloads ([0ad3b44](0ad3b44))
* **mobile:** status bar content are misaligned ([576e5b7](576e5b7))
* **responsiveness:** editor title overlapping if maxlength are met ([e526055](e526055))
* **shortcuts:** remove unwanted trigger button from shortcuts dialog that caused scroll issues ([ed6f9a7](ed6f9a7))
* **storage:** refining data from inavailable values of editor caused content merge ([35fa06b](35fa06b))
* **storage:** when new values introduced they take default values in case of old users ([aa6c0cd](aa6c0cd)), closes [#242](#242)
* **svelte:** svelte 5 `run` replaced using `effect` ([0eab892](0eab892))
* **tauri:** minimum width & height are added; exit not working on tauri ([5cc5847](5cc5847))
* temp ([92def1d](92def1d))
* **vite:** `manualChunks` incorrect config with pnpm ([733a8c9](733a8c9))

### Features

* editing filename limit update ([81f95b0](81f95b0))
* **menubar:** add a new button Display All Shortcuts ([d2d8374](d2d8374))
github-actions bot pushed a commit that referenced this issue Dec 2, 2024
@semantic-release-bot
chore(release): 1.0.0-alpha.4 [skip ci]
98752f6 
# [1.0.0-alpha.4](v1.0.0-alpha.3...v1.0.0-alpha.4) (2024-12-02)

### Bug Fixes

* **dialog:** made content scrollable, header & footer sticky ([1a2b443](1a2b443))
* **editor:** fake caret animation improvements ([b6d83b1](b6d83b1))
* **files:** file dialogs reappear after cancellation (open/save/save As) ([dc7c4a7](dc7c4a7)), closes [#243](#243)
* **menubar:** only show latest release downloads ([0ad3b44](0ad3b44))
* **mobile:** status bar content are misaligned ([576e5b7](576e5b7))
* **responsiveness:** editor title overlapping if maxlength are met ([e526055](e526055))
* **shortcuts:** remove unwanted trigger button from shortcuts dialog that caused scroll issues ([ed6f9a7](ed6f9a7))
* **storage:** refining data from inavailable values of editor caused content merge ([35fa06b](35fa06b))
* **storage:** when new values introduced they take default values in case of old users ([aa6c0cd](aa6c0cd)), closes [#242](#242)
* **svelte:** svelte 5 `run` replaced using `effect` ([0eab892](0eab892))
* **tauri:** minimum width & height are added; exit not working on tauri ([5cc5847](5cc5847))
* temp ([92def1d](92def1d))
* **vite:** `manualChunks` incorrect config with pnpm ([733a8c9](733a8c9))

### Features

* editing filename limit update ([81f95b0](81f95b0))
* **menubar:** add a new button Display All Shortcuts ([d2d8374](d2d8374))
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

🎉 This issue has been resolved in version 1.0.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Muhammed-Rahif Muhammed-Rahif

Labels
bug Something isn't working, should be fixed priority: critical Critical priority issue/pull request released on @alpha
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@Muhammed-Rahif