Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for auto-increment IDs in InMemoryDb provider #51

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

MrDave1999
Copy link
Owner

@MrDave1999 MrDave1999 commented Sep 2, 2024

This PR also fixes the exception thrown when the player tries to change their name.
The player's name cannot be used as a dictionary key, since it is valid to mutate it. For this reason an integer id has been generated as a key.

@MrDave1999 MrDave1999 added the feature New feature or request label Sep 2, 2024
@MrDave1999 MrDave1999 marked this pull request as ready for review September 2, 2024 22:18
@MrDave1999 MrDave1999 merged commit 2c7ee50 into dev Sep 2, 2024
1 check passed
@MrDave1999 MrDave1999 deleted the feat/InMemoryDb-auto-increment branch September 2, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant