Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rename methods to use 'AddPoints' prefix instead of 'GivePoints' #133

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

MrDave1999
Copy link
Owner

No description provided.

The previous name, "GivePoints", could imply that points are being awarded without indicating whether they are being added to an existing points. The new name, "AddPoints", explicitly conveys that points are being summed to the player’s current points.
…oints'

This implies that the new nomenclature emphasizes that points are being added to a player's current points, which provides better clarity on the action performed by the method.
@MrDave1999 MrDave1999 added feature New feature or request breaking-change Change API design or behavior and removed feature New feature or request labels Oct 5, 2024
@MrDave1999 MrDave1999 marked this pull request as ready for review October 5, 2024 19:27
@MrDave1999 MrDave1999 merged commit e1421f2 into dev Oct 5, 2024
1 check passed
@MrDave1999 MrDave1999 deleted the breaking-change branch October 5, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Change API design or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant