Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup tests, linting and codestyle checks #77

Merged
merged 12 commits into from
Oct 16, 2023
Merged

Setup tests, linting and codestyle checks #77

merged 12 commits into from
Oct 16, 2023

Conversation

thijskramer
Copy link
Collaborator

@thijskramer thijskramer commented Jun 2, 2023

This PR adds linting with Ruff, codestyle checks with black and a setup for testing with pytest.

The tests themselves are being written.

@thijskramer thijskramer force-pushed the setup-tests branch 5 times, most recently from 53e2f1f to 05d2121 Compare June 5, 2023 20:33
@Niicck
Copy link
Collaborator

Niicck commented Oct 13, 2023

Hi! Do you need any help with getting this PR finished?

I'm about to start another attempt at getting multi-configs to work (wip PR: Niicck#1). Having linting and testing in place beforehand would make that feel a lot safer.

@thijskramer
Copy link
Collaborator Author

Yes, help would be much appreciated! The reason I started writing tests was for the exact same reason: to feel much safer during refactoring.

@Niicck
Copy link
Collaborator

Niicck commented Oct 15, 2023

Cool, I got a PR into this branch that adds 100% Testing Coverage (#91). I appreciate you putting the whole testing framework into place.

Thijs Kramer and others added 10 commits October 16, 2023 09:30
* create patch_settings fixture

* 100% test coverage

---------

Co-authored-by: Ben Beecher <120373+gone@users.noreply.github.com>
Co-authored-by: Eddy Brown <eddybrown@me.com>
Co-authored-by: Thijs Kramer <1274867+thijskramer@users.noreply.github.com>
Co-authored-by: Niicck <niicck@users.noreply.github.com>
@thijskramer
Copy link
Collaborator Author

Cool, I got a PR into this branch that adds 100% Testing Coverage (#91). I appreciate you putting the whole testing framework into place.

Thank you very much for your efforts! I've merged your PR into this one. I'll merge this into master so that future pull requests will be tested.

@thijskramer thijskramer merged commit 4108c13 into master Oct 16, 2023
7 checks passed
@Niicck
Copy link
Collaborator

Niicck commented Oct 16, 2023

Awesome, thanks for merging that in. I'm working on a refactor that'll allow us to use multiple vite app configurations. That'll be up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants