-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup tests, linting and codestyle checks #77
Conversation
53e2f1f
to
05d2121
Compare
Hi! Do you need any help with getting this PR finished? I'm about to start another attempt at getting multi-configs to work (wip PR: Niicck#1). Having linting and testing in place beforehand would make that feel a lot safer. |
Yes, help would be much appreciated! The reason I started writing tests was for the exact same reason: to feel much safer during refactoring. |
Cool, I got a PR into this branch that adds 100% Testing Coverage (#91). I appreciate you putting the whole testing framework into place. |
* create patch_settings fixture * 100% test coverage --------- Co-authored-by: Ben Beecher <120373+gone@users.noreply.github.com> Co-authored-by: Eddy Brown <eddybrown@me.com> Co-authored-by: Thijs Kramer <1274867+thijskramer@users.noreply.github.com> Co-authored-by: Niicck <niicck@users.noreply.github.com>
94154c7
to
5891a46
Compare
5891a46
to
6c0e6d0
Compare
Thank you very much for your efforts! I've merged your PR into this one. I'll merge this into |
Awesome, thanks for merging that in. I'm working on a refactor that'll allow us to use multiple vite app configurations. That'll be up soon. |
This PR adds linting with Ruff, codestyle checks with black and a setup for testing with pytest.
The tests themselves are being written.