Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix exit fullscreen viewport scaling issues #845

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Fix exit fullscreen viewport scaling issues #845

merged 1 commit into from
Nov 27, 2018

Conversation

MortimerGoro
Copy link
Contributor

@MortimerGoro MortimerGoro commented Nov 27, 2018 •
edited
Loading

Fixes #833

@MortimerGoro MortimerGoro changed the title Fix exit fullscreen viewport scaling issues. Fixes #833 Fix exit fullscreen viewport scaling issues Nov 27, 2018
cvan
cvan approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to fix #833 (comment) - many thanks!

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/NavigationBarWidget.java
if (SessionStore.get().isInFullScreen()) {
SessionStore.get().exitFullScreen();
}
}, 50);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this solves the issue for now. shall we keep #833 open for a more proper investigation + solution after 1.1?

caseyyee
caseyyee approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@caseyyee caseyyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Works nicely!

@MortimerGoro MortimerGoro merged commit f5e522d into master Nov 27, 2018
@cvan cvan deleted the fullscreen_resize branch November 27, 2018 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@caseyyee caseyyee caseyyee approved these changes

@cvan cvan cvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MortimerGoro @cvan @caseyyee