This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #498
In this case, we do not extend GeckoSession but introduce a wrapper around all the things that need to be abstracted. This is still WIP (Servo part not done yet). But I would like to get some early feedback before finishing this.
Pros/Cons for the 2 approach:
take 1 - #498
Pros: lot less boilerplate code. Less intrusive
Cons: Will break easily with any GV update (like: https://bugzilla.mozilla.org/show_bug.cgi?id=1492771)
take 2
Pros: more solid to changes in GV
Cons: rather intrusive and requires quite a lot of boilerplate code.
@MortimerGoro What do you think?