Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #2883 Ensure webexts are loaded when restoring sessions #3364

Merged
merged 3 commits into from
May 18, 2020

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented May 12, 2020

Fixes #2883 Web extensions are not being loaded for restored sessions after a restart.

STRs:

  • Open a youtube video
  • Change the MSAA setting and restart
  • See the video URL (it has app=desktop appended)
  • Change the MSAA setting and restart again

Actual result: The loaded url after the first restart has app=desktop appended, the webextension hasn't been applied, after the second restart Youtube has an incorrect layout.

Expected result: The correct Youtube layout should be used for restored sessions.

This would happen with any extension.

@keianhzo keianhzo self-assigned this May 12, 2020
@keianhzo keianhzo requested a review from bluemarvin May 15, 2020 06:27
@keianhzo
Copy link
Contributor Author

keianhzo commented May 15, 2020

Opened #3379 to add a better way of notifying these type of events.

@bluemarvin bluemarvin added this to the #11 polish milestone May 15, 2020
@bluemarvin bluemarvin merged commit 22e6606 into master May 18, 2020
@bluemarvin bluemarvin deleted the v11/extensions_fix branch May 18, 2020 19:52
bluemarvin pushed a commit that referenced this pull request May 18, 2020
* Ensure webexts are loaded when restoring sessions

* Update to new webextensions API

* Restore sessions even if the extensions loading fails.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The YouTube layout changes after closing and reopening/restarting the app
2 participants