This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
History feed #1656
Merged
History feed #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
suggested changes
Aug 26, 2019
There was a problem hiding this comment.
I saw two issues while testing History so far:
- webxr.today is showing up in the history feed
STR: Open history, webxr.today is shown in the history feed. - redirects are showing up in the history feed
STR: Use google for a search. Click a link in the results. If you look at the history you will see the history redirect URL in the list. The GeckoView HistoryDelegate has flags so that you can filter out redirect URLs.
bluemarvin
approved these changes
Aug 26, 2019
|
I believe each unique URL should only appear once in the history list. |
|
The history and bookmarks windows not working on NoAPI and HTC seem to be a pre-existing issue as I can repro the bookmark issue on master. Once rebased, we should land. I'll file a different issue to fix the windows not being visible. |
Also avoid storing URLs manually and rely o the history delegate for all history management
Also fixed an issue with history sections and made the historyListener a delegate as having multiple listeners is not really necessary
Also fixed history cleanup ranges
|
Let land and address any issues in follow ups. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1283 Adds support for the History feed