This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Place the window a bit higher #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
requested review from
bluemarvin,
keianhzo,
philip-lamb and
jvonitter
|
One thing with the window higher is that when watching a 2D video in fullscreen, the back,projection,brightness menu is higher and it is really bright. I think it would be cool to have the option to hide the controllers and menus when in fullscreen like in immersive video mode. Otherwise I guess moving the window up a little doesn't bother me too much. |
|
On first glance, I love it! I'm passing the apk to Nadja and I want to use it for a while, but I think it's ok to merge and test. We should check it on different devices/platforms as I've only checked Quest so far. |
bluemarvin
approved these changes
Aug 8, 2019
|
Let's land so people can start testing. It's easy to change back if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the conversation and the images posted in #1511.
This is an attempt to try a bit higher window height. We should get feedback before landing it.
One problem we have compared to Oculus is that they have a fixed window height, so they have always centered in the same position. For us placing the window higher may feel good in the 1x size but has a bigger impact for the 2X 3X sizes. So we need to find a good balance.