Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Support for WaveVR appId #1476

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Support for WaveVR appId #1476

merged 3 commits into from
Aug 2, 2019

Conversation

keianhzo
Copy link
Contributor

Fixes #1458 Added a .wavevr for non-store WaveVR builds so we can install debug and staging builds without clashing with the preinstalled app id.

Also replace noapi x86 builds with x86_64.

MortimerGoro
MortimerGoro suggested changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@MortimerGoro MortimerGoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update https://github.com/MozillaReality/FirefoxReality/blob/master/tools/taskcluster/build_targets.py

@keianhzo
Copy link
Contributor Author

@MortimerGoro updated!

@keianhzo keianhzo requested a review from MortimerGoro July 31, 2019 13:40
philip-lamb
philip-lamb reviewed Aug 2, 2019
View reviewed changes
versions.gradle Outdated Show resolved Hide resolved
philip-lamb
philip-lamb reviewed Aug 2, 2019
View reviewed changes
app/build.gradle Outdated Show resolved Hide resolved
@keianhzo keianhzo merged commit aae8e54 into master Aug 2, 2019
@philip-lamb philip-lamb deleted the wavevr_appid branch August 5, 2019 04:36
This was referenced Dec 24, 2019
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philip-lamb philip-lamb philip-lamb approved these changes

@MortimerGoro MortimerGoro MortimerGoro approved these changes

@bluemarvin bluemarvin Awaiting requested review from bluemarvin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support staging specific appId
3 participants
@keianhzo @MortimerGoro @philip-lamb