Replace tags with category for index blog cards #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youriwims
changed the title
Pomax
changed the title
|
Styling looks perfect and /blog it's showing the category which is great. Styling looks great on https://foundation-mofostaging-pr-3637.herokuapp.com/en/blog/old-be-market-high-article-interesting/ but the Related Posts are still showing the first tag. Could they just show the category instead? I realize this wasn't clear in the ticket so feel free to file as a follow-up! |
|
Yep, I can update that now. |
|
Excellent thank you! |
kristinashu
approved these changes
Sep 12, 2019
Merged
|
Sorry Youri, I know I had asked for some font styling overrides of the category name but Mavis has pointed out in her PR #3641 that we probably shouldn't do that. Could you please update this to be the default |
Pomax
suggested changes
Sep 13, 2019
network-api/networkapi/wagtailpages/templates/wagtailpages/fragments/blog-card.html
Show resolved
Hide resolved
Pomax
reviewed
Sep 16, 2019
network-api/networkapi/wagtailpages/templates/wagtailpages/fragments/blog-card.html
Outdated
Show resolved
Hide resolved
Pomax
reviewed
Sep 16, 2019
network-api/networkapi/wagtailpages/templates/wagtailpages/fragments/blog-card.html
Outdated
Show resolved
Hide resolved
…gments/blog-card.html Co-Authored-By: Pomax <[email protected]>
…gments/blog-card.html Co-Authored-By: Pomax <[email protected]>
Pomax
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3563
View Index Page: https://foundation-mofostaging-pr-3637.herokuapp.com/en/blog/
View non-index blog page: https://foundation-mofostaging-pr-3637.herokuapp.com/en/blog/old-be-market-high-article-interesting/