Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alignment on Primary & Bannered Campaign Pages #3025

Merged
merged 10 commits into from
Apr 24, 2019
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<div class="container {{wrapper_class}}">
<div class="row">
<div class="col-12"><hr class="intro-and-content-divider" /></div>
</div>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,15 @@
{% include "./fragments/primary_heroguts.html" with root=root page=page %}
{% endblock %}

{% block content_wrapper_class %}{% endblock %}

{% block campaign_page_header %}{% endblock %}
{% block campaign_page_menu %}{% endblock %}

Note: Wrapper HTML elements are copied from primary_page_menu.html as we want menu on BanneredCampaignPage to look exactly the same as PrimaryPage's.

{% block minisite_title %}
<div id="multipage-nav-wrapper" class="hidden-sm-down full-width mb-4">
<div id="multipage-horizontal-nav-wrapper" class="hidden-sm-down full-width">
youriwims marked this conversation as resolved.
Show resolved Hide resolved
<div class="container">
<div class="row">
<div class="col-12">
Expand All @@ -24,6 +26,10 @@
</div>
{% endblock %}

{% block minisite_no_menu %}
{% include "partials/intro_and_content_divider.html" with wrapper_class="hidden-sm-down" %}
{% endblock %}

The following block has been borrowed from the templates/tags/cta/petition.html file,
rather than using the `cta` tag from our mini_site_tags collection, because the cta
tag was written in the assumption that models would only ever have a single CTA field
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
{% block donate %}{% endblock %}

{% block subcontent %}
<div class="py-4 py-md-5
<div class="
{% block content_wrapper_class %}py-4 py-md-5{% endblock %}
{% if page.specific.narrowed_page_content %}
offset-md-2
col-md-8
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% load wagtailcore_tags wagtailimages_tags %}

<div id="hero" class="mb-md-3">
<div id="hero">
<div class="banner">
{% if page.banner %}
<picture>
Expand All @@ -21,15 +21,17 @@
</div>

<div class="container">
<div class="row">
<div class="col-12 col-md-8">
<div class="cutout p-3 px-md-5 py-md-3">
<h1 class="h1-heading">{% if root.title %}{{ root.title }}{% elif page.header %}{{ page.header }}{% else %}{{ page.title }}{% endif %}</h1>
{% if page.intro %}
<p class="body-large mb-0">{{ page.intro }}</p>
{% endif %}
</div>
<div class="row no-gutters">
<div class="cutout col-12 col-md-8 pt-4">
<h1 class="h1-heading mb-0">{% if root.title %}{{ root.title }}{% elif page.header %}{{ page.header }}{% else %}{{ page.title }}{% endif %}</h1>
{% if page.intro %}
<p class="body-large mt-3 mb-0">{{ page.intro }}</p>
{% endif %}
</div>
</div>
</div>

{% if singleton_page == True %}
{% include "partials/intro_and_content_divider.html" with wrapper_class="hidden-md-up" %}
{% endif %}
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
</div>
</div>
</div>
{% else %}
{% block minisite_no_menu %}{% endblock %}
{% endif %}
{% endblock %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{% endblock %}

{% block content %}
{% include "partials/multipage-nav-mobile.html" with wrapper_classes="mb-3 mb-md-5" %}
{% include "partials/multipage-nav-mobile.html" %}

{% primary_page_menu page %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ <h1 class="h1-heading">{{ page.header }}</h1>

<div class="py-4">
{% include "partials/multipage-nav-mobile.html" with always_show_mobile_nav=True %}
<div id="multipage-nav-wrapper" class="hidden-sm-down full-width">
<div id="multipage-horizontal-nav-wrapper" class="hidden-sm-down full-width my-0">
<div class="container">
<div class="row">
<div class="col-12">
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% load wagtailcore_tags nav_tags %}

{% if singleton_page == False %}
<div id="multipage-nav-wrapper" class="hidden-sm-down full-width mb-4">
<div id="multipage-horizontal-nav-wrapper" class="hidden-sm-down full-width">
<div class="container">
<div class="row">
<div class="col-12">
Expand All @@ -10,4 +10,6 @@
</div>
</div>
</div>
{% else %}
{% include "partials/intro_and_content_divider.html" with wrapper_class="hidden-sm-down" %}
{% endif %}
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#multipage-nav-mobile {
@include intro-and-content-spacing();

.dropdown-nav {
.expander {
background: none;
Expand Down
6 changes: 4 additions & 2 deletions source/sass/components/multipage-nav.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#multipage-nav-wrapper {
#multipage-horizontal-nav-wrapper {
@include intro-and-content-spacing(true);

&.full-width {
@media (min-width: $bp-md) {
border-bottom: 1px solid $gray-20;
Expand All @@ -13,7 +15,7 @@
align-items: stretch;
border-bottom: 1px $gray-20 solid;

@at-root #multipage-nav-wrapper.full-width #{&} {
@at-root #multipage-horizontal-nav-wrapper.full-width #{&} {
border: none;
}

Expand Down
16 changes: 16 additions & 0 deletions source/sass/global.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,20 @@ button:hover {
}

.cutout {
$grid-gutter-width: map-get($grid-gutter-widths, xs);
$padding-x: #{$grid-gutter-width / 2};

margin-top: calc(#{$bg-pattern-height} - 40px);
background: white;
padding-left: $padding-x;
padding-right: $padding-x;

@media screen and (min-width: $bp-md) {
$offset-left: 24px;

margin-left: -$offset-left;
padding-left: $offset-left;
}
}
}

Expand Down Expand Up @@ -74,3 +86,7 @@ footer.site-footer {
}
}
}

hr.intro-and-content-divider {
@include intro-and-content-spacing(true);
}
12 changes: 12 additions & 0 deletions source/sass/mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,15 @@
text-decoration: underline;
}
}

@mixin intro-and-content-spacing($adjust-spacing-for-md: null) {
margin-top: 24px;
margin-bottom: 24px;

@if ($adjust-spacing-for-md) {
@media (min-width: $bp-md) {
margin-top: 48px;
margin-bottom: 48px;
}
}
}