-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Image Text2 component #2693
Comments
It looks like we're still using ImageTextBlock on nine pages so we'll have to switch those over to ImageTextBlock2 first before we can remove the original ImageTextBlock (which is a necessary step before we can start renaming things relating to ImageBlock2. Streamfield migrations are unfortunately even more complex than standard django model renames) |
Amazing that you can tell which pages are using it! I will update those tomorrow. |
Ok that was painfully tedious but they're all gone now! |
Super! On a CMS permissions note, can you see the "settings -> block inventory" option? I don't recall it being an explicit permission in the user group policies, but I also don't think we ever checked that everyone with CMS access can see it, even though it'd be super useful if everyone could. |
ah, perfect. Thanks for checking! |
I guess, feel free to do the renaming later if deleted the deprecated component is a blocker. |
Removing the "small" checkbox is going to impact at least one page on the existing site: https://foundation.mozilla.org/en/initiatives/responsible-cs/challenge/. Has an audit been done to understand the effects of this (and the URL removal)? I wonder if it might be better to rebuild this as a separate component called Image Text and deprecate ImageText2 |
ImageText2 (without the checkbox) has been used extensively on the site so replacing it would be a nightmare. I can certainly do an audit of where the "small" checkbox has been used and then replace those with |
@kristinashu, any updates on the 'small' checkbox audit? |
@kristinashu, what type of list(i.e. ordered/bulleted or unordered/no-bullets) did you want here? |
All those text styles should be the same as the |
marking as blocked until #2763 is on production (not just staging) |
#2763 got deployed to production, marking as unblocked again. |
w00t Youri! Looks like this is all done and working great! The final step is represented in - [Wagtail Component] Remove Image Text 2 Component #2793 |
This is probably blocked by - Remove deprecated components #1902 and Updates Figuregrid2 component #2696
Related to - New Image Text Mini component #2694
Based on design in #2282, component comps https://redpen.io/tuab5adf37d05d0414 and Fellowship comps https://redpen.io/p/mga45e3eeaaf9bc071.
Styling and CMS form fields
Test
so they match our style guide (H2-H6, normal body + large body, bold, italic, list, url link)Image Text2
toImage Text
[blocked by deprecating old component (Wagtail) Deprecated Image Text component needs to be removed from codebase #2739] - ok to hold off on name changeSmall
checkbox (this is nowImage text mini
)@alanmoo or @Pomax can you please either add to this ticket or open a separate one that includes additional steps for determining where this component is used and how we can make sure we don't break anything while doing these updates?
Component comp
The text was updated successfully, but these errors were encountered: