Elm says hello #221
Open
Elm says hello #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it resolves #49. I did a version that includes an Elm Architecture structure: https://github.com/lenards/Hello-World-Collection/commit/c585ae8d972c8a19aa81e5c2e2868e38352f9649 Which has much more going on (and might not be helpful to someone just starting out). If you're curious, I did an Ellie version as well that is hosted and you can start to tweak, extend, and play with in your browser. |
|
Can someone mark this with Hacktoberfest too? |
|
Ugh - it doesn't look like any pull requests have been closed since last October - is that right? |
|
Sorry - there were some commits in March. |
|
@lenards Sorry, I didn't see yours! I think both work fine! |
|
Yours is more simple Danny! I’m glad you submitted it.
Mine hasn’t been pull requested yet. The link is to my fork. I was about to
create the PR when I found yours.
…On Tue, Oct 2, 2018 at 8:41 PM dannyob ***@***.***> wrote:
@lenards <https://github.com/lenards> Sorry, I didn't see yours! I think
both work fine!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#221 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAXI-sWv2IQk72YUXt23wM2QSf7zEVFks5uhDHbgaJpZM4XDY_u>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #49, I hope!