fix(rendering): Don't try to set window icon on macOS #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to set the window icon on macOS results in an exception since [glfw/glfw@9a87c2a](glfw/glfw@9a87c2a). This will be printed out as an error by our default handler for GLFW errors. However, we can easily prevent this by not attempting to use this feature when running on macOS. + // Not supported on Mac: Code: 65548, Description: Cocoa: Regular windows do not have icons on macOS + GLFW.glfwSetWindowIcon(window, buffer);
skaldarnar
added
Topic: Rendering
skaldarnar
added
the
Size: S
keturn
reviewed
Aug 21, 2022
keturn
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to set the window icon on macOS results in an exception since
glfw/glfw@9a87c2a.
This will be printed out as an error by our default handler for GLFW
errors.
However, we can easily prevent this by not attempting to use this
feature when running on macOS.