Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(idea): fix parameters in run configurations #5065

Merged
merged 1 commit into from
Aug 21, 2022
Merged

build(idea): fix parameters in run configurations #5065

merged 1 commit into from
Aug 21, 2022

Conversation

skaldarnar
Copy link
Member

We must have missed these run configurations when we changed the way we do our
command line argument parsing. Only changes are correcting the way the
confiugration passes parameters to the game:

  • -homedir becomes --homedir
  • -noCrashReport becomes --no-crash-report
  • -noSpalsh becomes --no-splash

@skaldarnar skaldarnar added Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research labels Aug 21, 2022
@github-actions github-actions bot added the Type: Bug Issues reporting and PRs fixing problems label Aug 21, 2022
keturn
keturn approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, these are appropriate changes. 👍

@keturn keturn merged commit 4de6bdc into develop Aug 21, 2022
@keturn keturn deleted the chore/idea-run-configurations branch August 21, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keturn keturn keturn approved these changes

@jdrueckert jdrueckert Awaiting requested review from jdrueckert

Assignees
No one assigned
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Size: S Small effort likely only affecting a single area and requiring little to no research Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skaldarnar @keturn