Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance(network): shutdown faster with parallelization #5029

Merged
merged 4 commits into from
Jun 26, 2022

Conversation

keturn
Copy link
Member

@keturn keturn commented May 30, 2022

I found these things while trying to figure out why MTE tests take so long, though its not using much CPU for a lot of it.

The changes to NetworkSystemImpl help some by themselves, and by explicitly passing the "quiet time" parameter to shutdown(), we lay the groundwork for changing that value. I don't know if we ever want to wait two seconds for that, but in tests we very much do not!

The values of 2 and 15 seconds are the defaults netty has been using when we don't specify.

Thread.onSpinWait() tells the JVM this thread is just waiting, not doing useful work.

How to test

The changes are mostly about shutting down the network server (or client). I guess make sure that still behaves as expected without stalling?

The other extreme would be "too fast" instead of "too slow (stalling)", but I don't know "shuts down too fast" would show up as any sort of problem.

@keturn keturn added Category: Performance Requests, Issues and Changes targeting performance Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research labels May 30, 2022
Thread.onSpinWait() tells the JVM this thread is just waiting, not doing useful work.
mostly relevant for tests, which shutdown and restart often
@keturn keturn force-pushed the perf/fasterNetworkShutdown branch from 56baf59 to 6c7c280 Compare June 4, 2022 19:12
@keturn keturn merged commit 40db450 into develop Jun 26, 2022
@keturn keturn deleted the perf/fasterNetworkShutdown branch June 26, 2022 21:44
@keturn keturn changed the title performance(network): shutdown faster with parallization performance(network): shutdown faster with parallelization Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Performance Requests, Issues and Changes targeting performance Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants