Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(F3): show process data size and limit #4946

Merged
merged 4 commits into from
Nov 15, 2021
Merged

Conversation

keturn
Copy link
Member

@keturn keturn commented Nov 9, 2021

Adds the data size of the process to the F3 debug overlay. This is a value from the operating system, not the JVM.

f3-data-size

The new values are:

  • Data: 5850.3 / 6144.0 MB (95%)
    • 5850.3 MB is the size of this process's data segment and stack
    • 6144.0 MB is the maximum data size allowed by the --max-data-size=6G option I launched the game with
    • 95% is how close it is to that limit
  • Extra: 2778.3 MB is how much larger this data size is than the Total Memory number shown by the JVM

Only implemented for Linux.

How to Test

Push F3 to bring up the debug overlay while in game.

Try it with and without the --max-data-size option on Linux.

@keturn keturn added Category: Performance Requests, Issues and Changes targeting performance Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research labels Nov 9, 2021
@github-actions github-actions bot added the Type: Improvement Request for or addition/enhancement of a feature label Nov 9, 2021
@keturn keturn changed the title feat: show process data size and limit feat(F3): show process data size and limit Nov 9, 2021
@keturn
Copy link
Member Author

keturn commented Nov 13, 2021

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so if we don't set --max-data-size then data size is unlimited and we don't show any limit accordingly 💡
LGTM code-wise and tests out fine in-game 👍

@keturn keturn merged commit ce8d34f into develop Nov 15, 2021
@keturn keturn deleted the feat/debugOverlayRSS branch November 15, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Performance Requests, Issues and Changes targeting performance Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants