feat(JOML): migrate SectorUtils and Events #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging b4b306e into 19c233b - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging ed4b030 into dff2d73 - view on LGTM.com new alerts:
|
skaldarnar
added a commit
to Terasology/MultiBlock
that referenced
this pull request
Jan 9, 2021
skaldarnar
added a commit
to Terasology/FallingBlocks
that referenced
this pull request
Jan 9, 2021
skaldarnar
added a commit
to Terasology/FlowingLiquids
that referenced
this pull request
Jan 9, 2021
skaldarnar
added a commit
to Terasology-Archived/Pathfinding
that referenced
this pull request
Jan 9, 2021
skaldarnar
added a commit
to Terasology/GrowingFlora
that referenced
this pull request
Jan 9, 2021
skaldarnar
added a commit
to Terasology/MetalRenegades
that referenced
this pull request
Jan 9, 2021
skaldarnar
approved these changes
Jan 9, 2021
Comment on lines
+131
to
133
| Assertions.assertEquals(JomlUtil.from(chunkPosition), | ||
| ((OnChunkLoaded) mustBeOnLoadedEvent).getChunkPos(), | ||
| "Chunk position at event not expected"); |
There was a problem hiding this comment.
The order for assertions is expected, actual, message, so I corrected this while adding JomlUtil conversion to compare vectors of the same type.
jdrueckert
pushed a commit
to Terasology/MultiBlock
that referenced
this pull request
Jan 9, 2021
jdrueckert
pushed a commit
to Terasology/GrowingFlora
that referenced
this pull request
Jan 9, 2021
jdrueckert
pushed a commit
to Terasology/MetalRenegades
that referenced
this pull request
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3832
Module PRs