Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#228] Cleanup directories and update imports #229

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

2wheeh
Copy link
Collaborator

@2wheeh 2wheeh commented Mar 8, 2024

Resolves #228

Changes

디렉토리를 정리하고 그에따라 임포트 경로를 업데이트합니다.

컴포넌트의 경우, 아래의 이유로 Atomic 패턴을 따르는 것보다 도메인 > 런타임 으로 디렉토리를 구분하도록 합니다.

  1. 컴포넌트의 수가 많지 않은 점. Atomic 패턴을 따를 경우 불필요한 세분화로 복잡성이 증가할 우려가 있음.
  2. 도메인과 런타임에 따른 구분이 비즈니스 로직 연동 시 인지 비용이 적어 개발경험에 좋음.

@2wheeh 2wheeh added the ui Something about UI label Mar 8, 2024
@2wheeh 2wheeh self-assigned this Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

Copy link

github-actions bot commented Mar 8, 2024

Copy link
Collaborator

@isutare412 isutare412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고민의 흔적이 느껴지는군요.
고생하셨습니다! 👍

@2wheeh 2wheeh force-pushed the feature/issue-228/cleanup-directories branch from 7c524e0 to 25f3f89 Compare March 9, 2024 03:37
@2wheeh 2wheeh merged commit 13c1ce7 into develop Mar 9, 2024
2 checks passed
@2wheeh 2wheeh deleted the feature/issue-228/cleanup-directories branch March 9, 2024 03:37
Copy link

github-actions bot commented Mar 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Something about UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cleanup directories
2 participants