Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No search on enter if filters are unchanged #1631 #1642

Merged
merged 4 commits into from
Dec 1, 2019
Merged

No search on enter if filters are unchanged #1631 #1642

merged 4 commits into from
Dec 1, 2019

Commits on Mar 21, 2019

  1. No search on enter if filters are unchanged Mottie#1631 

    Fixing Mottie#1631 by not treating the enter key as a key press and thus not executing the search if enter is pressed while no filters were changed.
    @larsbonczek
    larsbonczek authored Mar 21, 2019
    Configuration menu
    Copy the full SHA
    e54611c View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. Fix search being canceled when filters emptied 

    Only reset the lastSearch and lastCombinedFilter variables if the filters were equal before. We don't need to "force filter refresh" if the filters were not equal anyways.
    @larsbonczek
    larsbonczek authored May 10, 2019
    Configuration menu
    Copy the full SHA
    210f496 View commit details
    Browse the repository at this point in the history

  2. Fix search being canceled when filters emptied 

    Only reset the lastSearch and lastCombinedFilter variables if the filters were equal before. We don't need to "force filter refresh" if the filters were not equal anyways.
    @larsbonczek
    larsbonczek authored May 10, 2019
    Configuration menu
    Copy the full SHA
    cf94af6 View commit details
    Browse the repository at this point in the history

  3. No search on enter if filters are unchanged Mottie#1631 

    Fixing Mottie#1631 by not treating the enter key as a key press and thus not executing the search if enter is pressed while no filters were changed.
    @larsbonczek
    larsbonczek authored May 10, 2019
    Configuration menu
    Copy the full SHA
    94c304d View commit details
    Browse the repository at this point in the history