Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use calculated index instead of DOM index #1424

Merged
merged 2 commits into from
Jul 2, 2017
Merged

Use calculated index instead of DOM index #1424

merged 2 commits into from
Jul 2, 2017

Commits on Jul 2, 2017

  1. Use calculated index instead of DOM index 

    There seems to be a scenario when there are multiple `thead` entries in a table where some versions of Firefox (around 47) return -1 for `cell.parentNode.rowIndex`, which winds up with the whole top part being laid out wrongly.

However, I looked this over and did not see any reason why not to use the calculated `i` for the row index instead.
    @ced-b
    ced-b authored Jul 2, 2017
    Configuration menu
    Copy the full SHA
    f1574b3 View commit details
    Browse the repository at this point in the history

  2. Fix accidental change of comment

    @ced-b
    ced-b authored Jul 2, 2017
    Configuration menu
    Copy the full SHA
    5366fd6 View commit details
    Browse the repository at this point in the history