Pager dropdown option with value same as "all".

[simenflatby]

Fixed an issue that occurred if you had an option in the pager dropdown with the same value as the total amount of table rows. When you selected such an option, the option with the value "all" was selected.

[Mottie]

Hi @simenflatby!

I'm out of the country with only my cell until next week so I won't be able to review this PR until then.

Would you please elaborate on the use case? To me, in my brief scan, it looks like this change will target the "all" option if it exists, or fallback to the same set size. Correct? If so, it sounds good to me, the pager widget would also need to be updated, but I can do that when I return.

[simenflatby]

Hi @Mottie

Elaboration as asked for:
Behaviour after the change:

• If any option other than "all" is chosen it's just set as before.
• If the "all" option is chosen it's just set as before.
• If an option with the same value as the total amount of rows in the table are chosen that option is set instead of the "all" option.

Before this change: If you have a total of 500 rows in your table and choose the 500 option, the "all" option is chosen.
After this change: If you have a total of 500 rows in your table and choose the 500 option, the 500 option is chosen.

<select>
    <option value="50" selected>50</option>
    <option value="100">100</option>
    <option value="500">500</option>
    <option value="all">All rows</option>
</select>

I'm sorry that I didn't update the pager widget. I actually didn't realize that it was a widget :-P

[Mottie]

Thanks again!

[Mottie]

I've updated the code you provided, please try the update in v2.28.6 to make sure I didn't break anything on your end. Thanks again!

[simenflatby]

Thank you. It now works like a charm 👍