Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pager plugin when the main table contains tables in a cell #196

Closed
cs01lg opened this issue Dec 17, 2012 · 6 comments
Closed

Pager plugin when the main table contains tables in a cell #196

cs01lg opened this issue Dec 17, 2012 · 6 comments
Labels

Comments

@cs01lg
Copy link

cs01lg commented Dec 17, 2012

If i have a 'main' table where one column has 'sub' tables in the cell contents

With the pager plugin when choosing the number of rows to display it seem to include the sub tables in the count so end up with too few rows

@Mottie
Copy link
Owner

Mottie commented Dec 17, 2012

Thanks, I'll look into this.

@Mottie
Copy link
Owner

Mottie commented Dec 18, 2012

I forgot to include a fix in v2.6, but I'll have it done in the next update! Thanks again.

@ghost
Copy link

ghost commented Dec 19, 2012

Have you got any tips on how one might fix this now? I have a similar issue; a table is inside the footer. I tried adding the cssInfoBlock class to that table, but this didn't help. Sorting doesn't work for all columns when this bug is present.

@Mottie
Copy link
Owner

Mottie commented Dec 19, 2012

I'll have the plugin updated within the hour :)

@Mottie Mottie closed this as completed in d0f48b1 Dec 19, 2012
@ghost
Copy link

ghost commented Dec 20, 2012

Hi, thanks for your quick work. You are great. However I think my bug is perhaps separate to this. It's not really related to the pager plugin which I incorrectly read here.

The issu is this; I just downloaded the new zip for this project, and changed the demo table in index.html to contain a section with this:

    <tfoot>
        <tr>
            <td colspan="4">
                <table>
                    <tr><td>test</td><td>test2</td></tr>
                </table>
            </td>
        </tr>
    </tfoot>

So you see there is a nested table there. When this happens, the sorting gets messed up (for the first 2 columns). Please try this out and let me know if you can reproduce this (Safari). Thanks.

@Mottie
Copy link
Owner

Mottie commented Dec 20, 2012

@wesleyh That is a separate issue. I was about to go to bed, but my OCD kicked in... if you change line #321 from this:

trs = $(t).find('thead:eq(0) tr, tfoot tr'),

to this

trs = $(t).find('thead:eq(0), tfoot').children('tr'),

it'll work properly. I'll include this change in the next update. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants