Pager doesn't show rows after changing sort order

[pevgeniev]

There is an issue with the pager when sorting twice on the same column. First it hides the rows, that are not in the current page, but after the reverse sort it doesn't show them.
The error is in renderTable when using pager_removeRows = true:

if ( !wo.pager_removeRows ) { tsp.hideRows( c ); } else{ ts.clearTableBody( table ); ....
The code in else adds the necessary number of rows, but since they already have display='none' set to them from the previous sort and there is no code to show them, they end up being hidden.
My initial fix was to call tsp.hideRows(c) befor the closing 'else' like:
ts.processTbody( table, $tb, false ); tsp.hideRows( c ); }
but since I don't know well enough this plugin, I don't know if that would be optimal and correct solution.

[Mottie]

Hi @pevgeniev!

I set up this demo using the pager widget with pager_removeRows set to true and I'm not seeing the problem. Would you please modify the demo to duplicate the problem you're seeing.

[pevgeniev]

Hi, I've updated the demo. Apparently the bug happens when one uses the widget-build-table.js plugin Regards

…

On Thu, Oct 19, 2017 at 3:28 PM, Rob Garrison ***@***.***> wrote: Hi @pevgeniev <https://github.com/pevgeniev>! I set up this demo <https://jsfiddle.net/Mottie/Lr6p93xu/22/> using the pager widget with pager_removeRows set to true and I'm not seeing the problem. Would you please modify the demo to duplicate the problem you're seeing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1466 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADGDqO5B73j7PafiChlPxQls0gRt6ErZks5st0BUgaJpZM4P-7XM> .

[pevgeniev]

Sorry, here it is: https://jsfiddle.net/Lr6p93xu/26/ On Thu, Oct 19, 2017 at 4:14 PM, petar tsvetanov <[email protected]> wrote:

…

Hi, I've updated the demo. Apparently the bug happens when one uses the widget-build-table.js plugin Regards On Thu, Oct 19, 2017 at 3:28 PM, Rob Garrison ***@***.***> wrote: > Hi @pevgeniev <https://github.com/pevgeniev>! > > I set up this demo <https://jsfiddle.net/Mottie/Lr6p93xu/22/> using the > pager widget with pager_removeRows set to true and I'm not seeing the > problem. Would you please modify the demo to duplicate the problem you're > seeing. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#1466 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ADGDqO5B73j7PafiChlPxQls0gRt6ErZks5st0BUgaJpZM4P-7XM> > . >

[Mottie]

Sorry, busy day... I'll look at this tomorrow.

[Mottie]

Sorry for the long delay! 😿This should be fixed in v2.30.0!